[PATCH] D23015: [ThinLTO/gold] Conservatively handle unknown GVs when internalizing
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 1 19:29:54 PDT 2016
tejohnson added a comment.
In https://reviews.llvm.org/D23015#502970, @mehdi_amini wrote:
> OK, let me backtrack, is the original issue coming from the fact that gold is starting with an empty module?
> Then why not changing this?
We use gold's symbol resolution to determine which values to link in. So in the example, it knows that f1 is a preempted symbol in %t2.o and doesn't need to include its definition. I don't think we should need to change that.
https://reviews.llvm.org/D23015
More information about the llvm-commits
mailing list