[PATCH] D23015: [ThinLTO/gold] Conservatively handle unknown GVs when internalizing

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D23015#502700, @tejohnson wrote:

> In https://reviews.llvm.org/D23015#502330, @mehdi_amini wrote:
>
> > Do we need gold for the test here or could it be written with an LLVM tool?
>
>
> Let me see if I can trigger without gold's symbol resolution


Can't trigger with llvm-lto. The gold-plugin uses the IRLinker to move the module being compiled (in that ThinLTO backend) into an empty module, indicating the ValuesToLink based on its symbol resolution decisions. Which is why we get f1 linked in only as a declaration for %t2.o, which means we need to create a local copy of it for the use via the alias, resulting in the naming conflict with the declaration. In llvm-lto, we simply use the module being compiled with a thinlto-action as is.


https://reviews.llvm.org/D23015