[PATCH] D23040: Tie the Verifier class to a Module; NFCI

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 17:21:06 PDT 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

FWIW, LGTM regardless of how you sequence the changes, but I like the changes suggested by David and Mehdi. Feel free to sort out with them here or IRC how to land this.


================
Comment at: lib/IR/Verifier.cpp:310
@@ -314,1 +309,3 @@
+    assert(&M == this->M &&
+           "An instance of this class only works with a specific module!");
     Context = &M.getContext();
----------------
mehdi_amini wrote:
> I'd just remove the Module parameter as part of the same patch. It becomes a sketchy invariant to be part of the API now.
+1


https://reviews.llvm.org/D23040





More information about the llvm-commits mailing list