[PATCH] D23040: Tie the Verifier class to a Module; NFCI

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 17:07:23 PDT 2016


majnemer added a subscriber: majnemer.

================
Comment at: lib/IR/Verifier.cpp:88
@@ -87,3 +87,3 @@
   raw_ostream *OS;
-  const Module *M = nullptr;
-  Optional<ModuleSlotTracker> MST;
+  const Module *M;
+  ModuleSlotTracker MST;
----------------
Should this be a reference now?

================
Comment at: lib/IR/Verifier.cpp:256-257
@@ -254,4 +255,4 @@
 
   void checkAtomicMemAccessSize(const Module *M, Type *Ty,
                                 const Instruction *I);
 
----------------
Should we remove this `M` parameter now?


https://reviews.llvm.org/D23040





More information about the llvm-commits mailing list