[PATCH] D23035: [Support] Add LLVM_BITFIELD_WIDTH and LLVM_CHECKED_BITFIELD_ASSIGN macros.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 16:42:02 PDT 2016


jlebar added a comment.

Added death tests.  Didn't realize we had those in LLVM.


================
Comment at: llvm/unittests/Support/BitfieldsTest.cpp:23-24
@@ +22,4 @@
+  };
+  // Can't stick LLVM_BITFIELD_WIDTH macro into EXPECT_EQ -- the two macros'
+  // magics are at odds.
+  int V;
----------------
chandlerc wrote:
> That's odd, even with parentheses around the macro?
EXPECT_EQ uses its args in unevaluated contexts, and that means we end up calling a lambda in an unevaluated context.  :)


https://reviews.llvm.org/D23035





More information about the llvm-commits mailing list