[PATCH] D22686: [WASM] SIMD128 support.

[Dan Gohman via llvm-commits]

sunfish accepted this revision.
sunfish added a reviewer: sunfish.
sunfish added a comment.

LGTM.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrInfo.td:113
@@ -106,1 +112,3 @@
 defm : ARGUMENT<F64>;
+defm : SIMD_ARGUMENT<v16i8>;
+defm : SIMD_ARGUMENT<v8i16>;
----------------
jpp wrote:
> If I use ARGUMENT<V128> instead of SIMD_ARGUMENT<V128>, then tablegen compains
> 
> In ARGUMENT_V128: Could not infer all types in pattern!
> 
> But this is at least not an assertion. :)
I think your analysis of the problem here is correct. The code here looks reasonable.

================
Comment at: lib/Target/WebAssembly/WebAssemblyPeephole.cpp:192
@@ +191,3 @@
+        Changed |=
+            Subtarget.hasSIMD128() &&
+            MaybeRewriteToFallthrough(MI, MBB, MF, MFI, MRI, TII,
----------------
These hasSIMD128() checks are also redundant, along the lines of my earlier comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D22686