[PATCH] D22837: [NVPTX] remove unnecessary named metadata update that happens to break debug info.

[David Blaikie via llvm-commits]

dblaikie added a comment.

"As far as I can tell, explicitly updating named metadata is not necessary -- updating metadata nodes for variables we've changed appears to maintain metadata consistency. I didn't manage to find a good way to verify it, though. If anyone has suggestions how to reference variable from named metadata, I can add it to the new test."

Not sure I understand what you were and were not able to verify/test. Could you explain that more/differently?

The test case looks fairly reasonable to me - but I also wouldn't mind an explanation of all the features (why the artificial/named metadata node? I would expect to just match the CU/Globals/global metadata nodes, and check that the reference (as you have) uses whatever is necessary (the addrspace casts, etc) to still reference that global)


https://reviews.llvm.org/D22837