[PATCH] D23022: [msf] Figure out the rest of the FPM and dump more detailed page allocation stats

[Zachary Turner via llvm-commits]

zturner added inline comments.

================
Comment at: lib/DebugInfo/PDB/Raw/PDBFile.cpp:130
@@ +129,3 @@
+  // of 4KB (very common), this would yield 32K total blocks in file, for a
+  // maximum file size of 32K * 4K = 134MB.  Obviously this won't do, so
+  // the Fpm is split across the file at `getBlockSize()` intervals.  As a
----------------
ruiu wrote:
> You are mixing kilo=1000 and kilo=1024 (32K=32*1024, 4K=4*1024, but 134MB=134*1000*1000). It's more accurate to say that the total is 128MB.
Ahh, thanks for catching that.  Gotta be careful using Google.  I wrote "4096 * 4096 * 8 bytes to megabytes" into Google and it told me the answer is 134 Megabytes.  I guess I have to write KiB and MiB to be accurate, ugh.


https://reviews.llvm.org/D23022