[PATCH] D21948: [DSE] fix - missing store to runtime stack in thunk with tail call bvval arg
Gerolf Hoflehner via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 1 12:41:19 PDT 2016
+ Reid
This was the DSE thread for fixing the tail - byval issue. I considered it a bandage from the beginning just to unblock an app. From the discussion and code I think the clang revert is much cleaner.
-Gerolf
> On Jul 2, 2016, at 5:15 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>
> eli.friedman added a subscriber: eli.friedman.
> eli.friedman added a comment.
>
> Special-casing this in DSE makes no sense... alias analysis should always return the correct result.
>
> In this case, alias analysis is correct; the definition of "tail" doesn't allow marking this call. If clang is generating code like this, it's a bug in clang.
>
>
> http://reviews.llvm.org/D21948
>
>
>
More information about the llvm-commits
mailing list