[llvm] r277290 - Fixed "copy-paste" mistake from revision 255245.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 09:27:11 PDT 2016


On Mon, Aug 1, 2016 at 9:22 AM Aboud, Amjad <amjad.aboud at intel.com> wrote:

> I guess we can add a LIT test using llvm-link.exe, this is why I figure
> out there is a typo mistake in the code.
>
> Do you suggest I add such a LIT test?
>
Generally, yes.

>
>
> Regards,
>
> Amjad
>
>
>
> *From:* David Blaikie [mailto:dblaikie at gmail.com]
> *Sent:* Monday, August 01, 2016 19:13
> *To:* Aboud, Amjad <amjad.aboud at intel.com>; llvm-commits at lists.llvm.org
> *Subject:* Re: [llvm] r277290 - Fixed "copy-paste" mistake from revision
> 255245.
>
>
>
> Is this testable?
>
>
>
> On Sun, Jul 31, 2016 at 7:49 AM Amjad Aboud via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> Author: aaboud
> Date: Sun Jul 31 09:41:50 2016
> New Revision: 277290
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277290&view=rev
> Log:
> Fixed "copy-paste" mistake from revision 255245.
>
> Modified:
>     llvm/trunk/lib/IR/LLVMContextImpl.h
>
> Modified: llvm/trunk/lib/IR/LLVMContextImpl.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/LLVMContextImpl.h?rev=277290&r1=277289&r2=277290&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/IR/LLVMContextImpl.h (original)
> +++ llvm/trunk/lib/IR/LLVMContextImpl.h Sun Jul 31 09:41:50 2016
> @@ -928,7 +928,7 @@ template <> struct MDNodeKeyImpl<DIMacro
>
>    bool isKeyOf(const DIMacroFile *RHS) const {
>      return MIType == RHS->getMacinfoType() && Line == RHS->getLine() &&
> -           File == RHS->getRawFile() && File == RHS->getRawElements();
> +           File == RHS->getRawFile() && Elements == RHS->getRawElements();
>    }
>    unsigned getHashValue() const {
>      return hash_combine(MIType, Line, File, Elements);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160801/e89c36ea/attachment.html>


More information about the llvm-commits mailing list