[PATCH] D22935: Make CommonInputSection singleton class.

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 02:46:26 PDT 2016

Previous message: [llvm] r277333 - Fixed MSVC out of range shift warning
Next message: [PATCH] D22935: Make CommonInputSection singleton class.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

evgeny777 added a comment.

Rui, I wonder why have you removed zero(&Hdr) from CommonInputSection constructor?
The InputSectionBase<ELFT> constructor reads sh_addralign from Hdr to calculate Alignment field, and this can be done incorrectly in case Hdr is not zeroed


Repository:
  rL LLVM

https://reviews.llvm.org/D22935

Previous message: [llvm] r277333 - Fixed MSVC out of range shift warning
Next message: [PATCH] D22935: Make CommonInputSection singleton class.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list