[PATCH] D22956: Ajust two tests implementation of TargetParserTest
jojo.ma via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 1 02:21:05 PDT 2016
jojo added a comment.
three choices:
1. Just iterate to AEK_RAS, as shown in this diff. (smallest change)
As AEK_RAS in the enum is the last one supported in the current design,so iterate to it may seems odd but is enough.
2. Add option AEK_LAST to enum ArchExtKind,then iterate to AEK_LAST.(biggest change, I prefer this one)
The current definition of ArchExtKind is as follow,adding an end option like FPUKind and ArchKind maybe better. Update diff
for this one.
enum ArchExtKind : unsigned {
AEK_INVALID = 0x0,
AEK_NONE = 0x1,
AEK_CRC = 0x2,
AEK_CRYPTO = 0x4,
AEK_FP = 0x8,
AEK_HWDIV = 0x10,
AEK_HWDIVARM = 0x20,
AEK_MP = 0x40,
AEK_SIMD = 0x80,
AEK_SEC = 0x100,
AEK_VIRT = 0x200,
AEK_DSP = 0x400,
AEK_FP16 = 0x800,
AEK_RAS = 0x1000,
// Unsupported extensions.
AEK_OS = 0x8000000,
AEK_IWMMXT = 0x10000000,
AEK_IWMMXT2 = 0x20000000,
AEK_MAVERICK = 0x40000000,
AEK_XSCALE = 0x80000000,
};
3. iterate over kHWDivKinds and kARMArchExtKinds
rengolin,What is your opinion?
https://reviews.llvm.org/D22956
More information about the llvm-commits
mailing list