[PATCH] D22908: [ARM] Improve isel of smul and smla instructions for thumb2

[Renato Golin via llvm-commits]

rengolin added a comment.

The patch looks sensible, but there's a lot of unneeded reorganization. Also, a slightly more descriptive commit message would be nice.

cheers,
--renato


================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:2631
@@ -2639,1 +2630,3 @@
                                    (sra rGPR:$Rm, (i32 16))))]>;
+def t2SMULBB : T2ThreeRegSMUL<0b001, 0b00, "smulbb",
+               [(set rGPR:$Rd, (mul (sext_inreg rGPR:$Rn, i16 ),
----------------
No need to move this code around, it just makes it harder to git-blame later.

================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:2665
@@ -2666,1 +2664,3 @@
                                                  (sra rGPR:$Rm, (i32 16)))))]>;
+def t2SMLABB : T2FourRegSMLA<0b001, 0b00, "smlabb",
+               [(set rGPR:$Rd, (add rGPR:$Ra,
----------------
Same here, if you can keep the same order, it's easier to review.

================
Comment at: test/CodeGen/ARM/smul.ll:10
@@ +9,3 @@
+; CHECK-NOT: sxth
+; CHECK: {{smulbt r0, r0, r1|smultb r0, r1, r0}}
+; CHECK-THUMBV6-NOT: {{smulbt|smultb}}
----------------
Same here, try to keep the same tests on their original positions and namings.


https://reviews.llvm.org/D22908