[PATCH] D22247: [DAGCombine] Make sext(setcc) combine respect getBooleanContents()

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 30 01:46:42 PDT 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM, although there is still the question of whether the test can be reduced any.

At the very least, if it cannot be reduced, please clearly comment the test case so that a future maintainer who needs to understand the intent of the test knows how to effectively update it.


https://reviews.llvm.org/D22247





More information about the llvm-commits mailing list