[PATCH] D12067: AMDGPU: Refactor exp instructions

[Matt Arsenault via llvm-commits]

arsenm added a comment.

In https://reviews.llvm.org/D12067#486407, @axeldavy wrote:

> In https://reviews.llvm.org/D12067#484345, @arsenm wrote:
>
> > Update for trunk. Set mayLoad = 1 for EXP_DONE instead of hasSideEffects
>
>
> Could you explain why ? To me it looks like hasSideEffects is the only way to guarantee the exp with the done bit is last.
>
> Btw you forgot to update the comments in the part "Export opcodes" to reflect that change.


I see some regressions with the mayLoad bit set for exp_done, but without it I see minimal changes: https://ghostbin.com/paste/b6ypo

I can drop the separate bit setting part of this patch for now and revisit it later


https://reviews.llvm.org/D12067