[PATCH] D22120: Move inline threshold related flags to InlineSimple.cpp

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 20:46:24 PDT 2016


davidxl added inline comments.

================
Comment at: include/llvm/Analysis/InlineCost.h:118
@@ +117,3 @@
+  /// The default threshold to start with for a callee.
+  int DefaultThreshold;
+  /// Threshold to use for callees with inline hint.
----------------
davidxl wrote:
> I prefer this one be called 'InlineThreshold' (to not be confused with the internal option) and document how it is set.
Or perhaps keeping this parameter name but changing the option name to be InlineThreshold (not Default...)


https://reviews.llvm.org/D22120





More information about the llvm-commits mailing list