[PATCH] D22990: [ELF] Implement R_ARM_TARGET1

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 19:16:00 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/Config.h:1
@@ -1,1 +1,2 @@
+
 //===- Config.h -------------------------------------------------*- C++ -*-===//
----------------
Revert.

================
Comment at: ELF/Relocations.cpp:538
@@ -537,3 +537,3 @@
     SymbolBody &Body = File.getRelocTargetSym(RI);
-    uint32_t Type = RI.getType(Config->Mips64EL);
+    uint32_t Type = Target->modifyReloc(RI.getType(Config->Mips64EL));
 
----------------
This affects all targets even though only ARM needs it. It is better to add cases for TARGET1 relocation to ARMTargetInfo::getRelExpr and ARMTargetInfo::relocateOne instead.


https://reviews.llvm.org/D22990





More information about the llvm-commits mailing list