[PATCH] D22980: Imported statistics types changes

[Vedant Kumar via llvm-commits]

vsk added a subscriber: vsk.
vsk added a comment.

Mostly looks fine, just two nitpicks.


================
Comment at: lib/Transforms/Utils/ImportedFunctionsInliningStatistics.cpp:55
@@ -53,2 +54,3 @@
     // Save Caller as a starting node for traversal.
-    NonImportedCallers.push_back(Caller.getName());
+    NonImportedCallers.push_back(It->first());
+  }
----------------
Does this line need to change?

================
Comment at: lib/Transforms/Utils/ImportedFunctionsInliningStatistics.cpp:186
@@ -188,1 +185,3 @@
+  for (const auto & Node : NodesMap)
+    SortedNodes.push_back(&Node);
 
----------------
It would probably be clearer to either change the `const auto &` to `std::unique_ptr<...> &` or to use `Node.get()` here.


https://reviews.llvm.org/D22980