[PATCH] D22898: AMDGPU: Fix ffloor for SI

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 17:27:45 PDT 2016


arsenm added a comment.

In https://reviews.llvm.org/D22898#499043, @nhaehnle wrote:

> Is the MIN needed for correctness at all? Looking at the workaround docs, I see the explanation that "[FRACT] is outputting 1.0 for very small negative inputs). Sounds to me like v_fract is correctly in the range [0, 1.0), except for those very small negative inputs, where it returns 1.0 (which happens to be correct for the ffloor lowering).


I guess so? I don't know the details of the bug but this passes conformance now


https://reviews.llvm.org/D22898





More information about the llvm-commits mailing list