[PATCH] D22966: GVN-hoist: compute MSSA once per function (PR28670)

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 16:01:16 PDT 2016


dberlin added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/GVNHoist.cpp:748
@@ -746,1 +747,3 @@
+        if (MemoryAccess *MA = MSSA->getMemoryAccess(Repl))
+          NewMemAcc = dyn_cast<MemoryUseOrDef>(MA);
       }
----------------
This will not work.
You have to   removeAccess(Repl), then createMemoryAccessAfter (access for hoist point).



https://reviews.llvm.org/D22966





More information about the llvm-commits mailing list