[PATCH] D22683: [ELF] Symbol assignment within input section list

[Rui Ueyama via llvm-commits]

I wasn't thought enough when I wrote the comment to suggest using
DefinedRegular, so I didn't notice there could be things like `. =
ALIGN(8)`. My original intention was you could attach all symbols to
beginning or ending of input sections. As it's not, I agree that the use of
DefinedRegular doesn't make much sense here.

On Fri, Jul 29, 2016 at 12:55 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> > That was Rui's suggestion to use DefinedRegular. My initial suggestion
> > (though it contained a bug) was about using DefinedSynthetic and setting
> > offset within output section,
> > not input section. I hardly see difference between these approaches - to
> my
> > understanding they are of equal implementation complexity. May be Rui
> tell
> > us, what he thinks.
>
> For now I think they are probably comparable, but avoiding
> OutputSection<ELFT>::assignOffsets and not creating a new input
> section type is probably more future proof for implementing ". =
> ALIGN" inside output sections.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/5cca4873/attachment.html>