[PATCH] D22491: Added ThinLTO inlining statistics

[Piotr Padlewski via llvm-commits]

Ok, I am waiting for my build to finish to send my patch.

Anyway I thinkt that MSVC2013 support should be dropped :P

2016-07-29 11:19 GMT-07:00 Mehdi Amini <mehdi.amini at apple.com>:

> It is possible that the bot was already red for another reason, in this
> case it won’t send an email when the other problem is fixed and it is
> failing because of your commit.
>
> On Jul 29, 2016, at 10:51 AM, Piotr Padlewski <piotr.padlewski at gmail.com>
> wrote:
>
> That's weird, I didn't get any email.
>
> 2016-07-29 10:47 GMT-07:00 Mehdi Amini <mehdi.amini at apple.com>:
>
>> VS 2013 is a supported configuration, you need to fix your patch quickly
>> (or revert in the meantime).
>>
>> Bots are broken in the meantime:
>> http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/9403/steps/build%20stage%201/logs/stdio
>>
>>
>>
>> On Jul 29, 2016, at 10:40 AM, Piotr Padlewski <piotr.padlewski at gmail.com>
>> wrote:
>>
>> It seems like a bug in VS 2013. Did you try using 2015?
>>
>> 2016-07-29 7:36 GMT-07:00 Yaxun Liu <yaxun.liu at amd.com>:
>>
>>> yaxunl added a subscriber: yaxunl.
>>> yaxunl added a comment.
>>>
>>> Hi,
>>>
>>> This commit caused build failure in Visual Studio 2013:
>>>
>>> 55>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(51):
>>> error C2610:
>>> 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::InlineGraphNode(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &&)' : is not a special member function which can be defaulted
>>> 55>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(52):
>>> error C2610: 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::operator
>>> =(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode &&)' : is not
>>> a special member function which can be defaulted
>>> 59>  CGOpenMPRuntime.cpp
>>> 58>  clangBasic.vcxproj ->
>>> C:\p4\stg_win60\git-llvm-tot\build\Debug\lib\clangBasic.lib
>>> 56>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(51):
>>> error C2610:
>>> 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::InlineGraphNode(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &&)' : is not a special member function which can be defaulted
>>> (C:\p4\stg_win60\git-llvm-tot\llvm\lib\Transforms\IPO\InlineSimple.cpp)
>>> 56>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(52):
>>> error C2610: 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::operator
>>> =(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode &&)' : is not
>>> a special member function which can be defaulted
>>> (C:\p4\stg_win60\git-llvm-tot\llvm\lib\Transforms\IPO\InlineSimple.cpp)
>>> 56>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(51):
>>> error C2610:
>>> 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::InlineGraphNode(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &&)' : is not a special member function which can be defaulted
>>> (C:\p4\stg_win60\git-llvm-tot\llvm\lib\Transforms\IPO\InlineAlways.cpp)
>>> 56>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(52):
>>> error C2610: 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::operator
>>> =(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode &&)' : is not
>>> a special member function which can be defaulted
>>> (C:\p4\stg_win60\git-llvm-tot\llvm\lib\Transforms\IPO\InlineAlways.cpp)
>>> 56>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(51):
>>> error C2610:
>>> 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::InlineGraphNode(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &&)' : is not a special member function which can be defaulted
>>> (C:\p4\stg_win60\git-llvm-tot\llvm\lib\Transforms\IPO\Inliner.cpp)
>>> 56>C:\p4\stg_win60\git-llvm-tot\llvm\include\llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h(52):
>>> error C2610: 'llvm::ImportedFunctionsInliningStatistics::InlineGraphNode
>>> &llvm::ImportedFunctionsInliningStatistics::InlineGraphNode::operator
>>> =(llvm::ImportedFunctionsInliningStatistics::InlineGraphNode &&)' : is not
>>> a special member function which can be defaulted
>>> (C:\p4\stg_win60\git-llvm-tot\llvm\lib\Transforms\IPO\Inliner.cpp)
>>>
>>>
>>> Repository:
>>>   rL LLVM
>>>
>>> https://reviews.llvm.org/D22491
>>>
>>>
>>>
>>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/22634c3b/attachment.html>