[PATCH] D22886: [llvm] Loop Vectorization fault in collectLoopUni

[Adam Nemet via llvm-commits]

anemet added inline comments.

================
Comment at: llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp:4839-4844
@@ -4838,8 +4838,8 @@
   BasicBlock *Latch = TheLoop->getLoopLatch();
   // Start with the conditional branch.
   if (!isOutOfScope(Latch->getTerminator()->getOperand(0))) {
     Instruction *Cmp = cast<Instruction>(Latch->getTerminator()->getOperand(0));
     Worklist.insert(Cmp);
     DEBUG(dbgs() << "LV: Found uniform instruction: " << *Cmp << "\n");
   }
 
----------------
anemet wrote:
> Hi Wei,
> 
> AFAICT, you introduced this code in D21755.  It would be great if you could explain the rationale/add a comment for the isOutOfScope part (especially that it has led to this bug).
> 
> Also, was there a test added for the case of an out-of-scope condition in D21755?
> 
> Thank you,
> Adam
@wmi, did you see this request?  It's not urgent; I just wanted to make sure that it does not get lost.


Repository:
  rL LLVM

https://reviews.llvm.org/D22886