[PATCH] D22639: Add flag to PassManagerBuilder to disable GVN Hoist Pass.

Robinson, Paul via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 09:33:37 PDT 2016


(Remembering to add llvm-commits this time)
I thought I looked for –gvn-hoist in the opt options, I guess I missed it!  Sorry for the noise.
--paulr


From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf Of Alina Sbirlea via llvm-commits
Sent: Friday, July 29, 2016 9:03 AM
To: reviews+D22639+public+adcb342fcd87e7cc at reviews.llvm.org
Cc: sebpop at gmail.com; llvm-commits; benny.kra at gmail.com; Davide Italiano
Subject: Re: [PATCH] D22639: Add flag to PassManagerBuilder to disable GVN Hoist Pass.

I would guess that yes? just my optinion.
GVN is disabled by default, hence the need to add `-enable-gvn-hoist` for any opt level >=O1 (vs DCE which is enabled by default). On the other hand explicitly adding `-gvn-hoist` should also work, just like adding `-dce`.

On Fri, Jul 29, 2016 at 8:34 AM, Paul Robinson <paul.robinson at sony.com<mailto:paul.robinson at sony.com>> wrote:
probinson added a subscriber: probinson.
probinson added a comment.

This means to enable the pass in opt I need to do both `-enable-gvn-hoist` and `-O1` which is not usual for opt.  (For example I need just `-dce` to get DCE.)  Is that the intent?


Repository:
  rL LLVM

https://reviews.llvm.org/D22639



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/a24e5856/attachment-0001.html>


More information about the llvm-commits mailing list