[PATCH] D22960: [ELF] LinkerScript: Implement custom output section factory
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 29 08:57:46 PDT 2016
ruiu added a comment.
Honestly this does not seem to simplify things. It may, but it also introduces new complexities. We now have BaseFactory and two Factory classes, and we are doing some object-oriented juggling there. Not sure if we can get rid of it (maybe we can just remove the base class and have two classes?) But at least for https://reviews.llvm.org/D22683, I'd say we want to just use the existing factory if this patch can't be simplified.
https://reviews.llvm.org/D22960
More information about the llvm-commits
mailing list