[PATCH] D22962: [ELF] - Linkerscript cleanup of LinkerScript<ELFT>::createSections()

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 08:40:47 PDT 2016


So, the main change is then to having a map to a vector instead of
having a multimap like interface, so I agree that we can try without.

On 29 July 2016 at 11:08, George Rimar <grimar at accesssoftek.com> wrote:
> grimar added a comment.
>
> In https://reviews.llvm.org/D22962#500640, @rafael wrote:
>
>> LGTM with one change.
>
>
> With this change it transforms almost to the same code. Actually comment of LinkerScript<ELFT>::getSectionMap() was depricated and I did not notice it returns InputSectionDescription already.
>
> So my patch can live without that change I think. Do you still think it is useful ?
>
>
> https://reviews.llvm.org/D22962
>
>
>


More information about the llvm-commits mailing list