[PATCH] D22956: Ajust two tests implementation of TargetParserTest

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: unittests/Support/TargetParserTest.cpp:217
@@ +216,3 @@
+TEST(TargetParserTest, ARMArchExtName) {
+  for (ARM::ArchExtKind AEK = static_cast<ARM::ArchExtKind>(0);
+       AEK <= ARM::ArchExtKind::AEK_RAS;
----------------
You could iterate over kHWDivKinds and kARMArchExtKinds?

================
Comment at: unittests/Support/TargetParserTest.cpp:218
@@ +217,3 @@
+  for (ARM::ArchExtKind AEK = static_cast<ARM::ArchExtKind>(0);
+       AEK <= ARM::ArchExtKind::AEK_RAS;
+       AEK = static_cast<ARM::ArchExtKind>(static_cast<unsigned>(AEK) + 1))
----------------
Shouldn't this be "< AEK_LAST"?


https://reviews.llvm.org/D22956