[PATCH] D22749: [ELF] - Linkerscript: Implemented SORT command

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

There are at least two independent cleanups. They LGTM. Can you commit them and rebase this?


================
Comment at: ELF/LinkerScript.cpp:119
@@ +118,3 @@
+template <class ELFT>
+static void addSection(OutputSectionFactory<ELFT> &Factory,
+                       std::vector<OutputSectionBase<ELFT> *> &Out,
----------------
Can you commit making this a static function as an independent cleanup?

================
Comment at: ELF/LinkerScript.h:145
@@ -143,3 +144,3 @@
 private:
-  std::vector<std::pair<StringRef, const InputSectionDescription *>>
+  std::vector<std::pair<StringRef, ArrayRef<std::unique_ptr<BaseCommand>>>>
   getSectionMap();
----------------
Can you commit just the change to return more info first?


https://reviews.llvm.org/D22749