[PATCH] D22890: AArch64: Add missing branch relaxation tests

[Diana Picus via llvm-commits]

rovka added inline comments.

================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:134
@@ +133,3 @@
+  // Verify the displacement bits options have sane values.
+  // XXX: Is there a better place for this?
+  assert(MaxOffs >= 8 &&
----------------
arsenm wrote:
> arsenm wrote:
> > rovka wrote:
> > > I'd rather move this closer to the point of use, because that would make the need for it clearer. But that's just personal preference.
> > Do you mean into the pass itself?
> I'm trying to move the target specific details out of the pass, to I don't think it should go there
No, I guess the pass itself is too far off, and it's probably just as well if it lives here or in isBranchInRange. LGTM as it is, thanks.


https://reviews.llvm.org/D22890