[PATCH] D22921: [asan] Reduce flakiness of heavy recovery mode tests.

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 01:43:09 PDT 2016


m.ostapenko added a comment.

In https://reviews.llvm.org/D22921#499745, @eugenis wrote:

> Is this the same write() atomicity issue as in test/msan/fork.cc ?


Yeah, exactly the same.

> Does piping the output directly to FileCheck help?


I'm afraid we can't use pipe here, because we have 2 possible outputs:

  // RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 10.txt
  .....
    // CHECK-COLLISION: AddressSanitizer: nested bug in the same thread, aborting
    // CHECK-NO-COLLISION: All threads terminated


Repository:
  rL LLVM

https://reviews.llvm.org/D22921





More information about the llvm-commits mailing list