[PATCH] D22911: [compiler-rt][XRay] Address follow-up comments to initial interface and initialisation code

[Dean Michael Berris via llvm-commits]

dberris added inline comments.

================
Comment at: lib/xray/xray_init.cc:35
@@ -37,1 +34,3 @@
+// __stop_xray_instr_map) to initialise the instrumentation map that XRay uses
+// for runtime patching/unpatching of instrumentation points.
 std::atomic<bool> XRayInitialized{false};
----------------
eugenis wrote:
> This only works for the main executable, right? Is this a temporary limitation? I imagine you could emit constructors to all DSOs that would add per-DSO sled maps to the global list.
> 
Currently, yes. I haven't quite thought out a solution for DSO's as it hasn't come up yet.

But as you mention, yes we can do something special for DSO's that would be treated especially by the runtime. I've added a FIXME to indicate that.


https://reviews.llvm.org/D22911