[PATCH] D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 23:50:02 PDT 2016


silvas accepted this revision.
silvas added a reviewer: silvas.
silvas added a comment.
This revision is now accepted and ready to land.

LGTM with a nit


================
Comment at: test/Transforms/CodeExtractor/InheritTargetAttributes.ll:3
@@ +2,3 @@
+; RUN: opt < %s -partial-inliner -S | FileCheck %s
+; This testcase tests inheriting target attributes
+
----------------
Can you mention what explicitly goes wrong if we don't inherit them?


https://reviews.llvm.org/D22713





More information about the llvm-commits mailing list