[PATCH] D22694: [Inliner, OptDiag] Add hotness attribute to opt diagnostics

[Adam Nemet via llvm-commits]

anemet added a comment.

In https://reviews.llvm.org/D22694#500037, @eraman wrote:

> This computes DominatorTree, LoopInfo, BPI and BFI for *every callsite* that is considered for inlining. Even though this is (I assume) turned off by default, it's still very expensive.


Certainly it is off by default and it's meant as a performance analysis tool so the budget is different.  That said, we can I guess cache ORE per caller and only invalidate it once we inline.  Does that sound reasonable to you?

> Even in the new PM, this can be avoided only by incrementally updating the BFI of the caller after inlining a callee into it.


Sure but I thought that was required for PGO-based inlining anyway.  I was hoping to piggyback on that.


https://reviews.llvm.org/D22694