[PATCH] D22912: [ELF] - Linkerscript: implemented ASSERT() keyword.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: test/ELF/linkerscript/linkerscript-assert.s:4
@@ +3,3 @@
+
+# RUN: echo "SECTIONS { \
+# RUN:  .aaa         : { *(.aaa) } \
----------------
grimar wrote:
> ruiu wrote:
> > I don't think we need this complex test case. This can just be something like
> > 
> >   ASSERT(0, "fail");
> > 
> > and
> > 
> >   ASSERT(1, "success");
> Ok + I suggest at least to check the return value of ASSERT as it probably can be used and
> already had trobles above.
You can add one more test

  ASSERT(ASSERT(42, "success") == 42, "success");


https://reviews.llvm.org/D22912