[PATCH] D22916: [ELF] - Linkerscript: implemented += operator.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:922-923
@@ -918,3 +921,4 @@
   if (Tok.getAsInteger(0, V)) {
-    if (!isValidCIdentifier(Tok))
+    if (Tok != "." && !isValidCIdentifier(Tok))
       setError("malformed number: " + Tok);
+    return [=](uint64_t Dot) { return getSymbolValue(Tok, Dot); };
----------------
ruiu wrote:
> I think you can remove this error check. If Tok is not a valid symbol name, getSymbolValue will find it.
Looks few tests begins to fail if I remove. Since this line is not added by this patch, I suggest to leave it for now, I'll check how to remove it and prepare a patch tomorrow.


https://reviews.llvm.org/D22916