[PATCH] D22858: Fix DbgValue handling in SelectionDAG.

Nirav Davé via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 14:01:46 PDT 2016


The fact that Hans still found the error after the r277027 patch is
evidence that the second part of this patch is necessary as well (testing
with Ismall showed that r277027 was necessary so both are needed). I think
that indirectly answers the remaining question of whether copying or moving
debug values is the right thing to do and we should be okay upstreaming
this patch.

On Thu, Jul 28, 2016 at 4:36 PM, Yaron Keren <yaron.keren at gmail.com> wrote:

> yaron.keren added a comment.
>
> PR28749 was created with trunk clang on Ubuntu x64.
> It reproduced reliably but is very fragile, changing just about anything
> in the code makes the problem disappear.
>
>
> https://reviews.llvm.org/D22858
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160728/fe9577c0/attachment.html>


More information about the llvm-commits mailing list