[PATCH] D22488: [IR] Introduce a non-integral pointer type

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: docs/LangRef.rst:1854-1855
@@ -1834,1 +1853,4 @@
+``ni:<address space>``
+    This specifies the pointer type with the address space ``<address space>``
+    as a :ref:`Non-Integral Pointer Type <nointptrtype>`.
 
----------------
Maybe mention this isn't allowed for AS 0?

================
Comment at: include/llvm/IR/DataLayout.h:206
@@ -201,2 +205,3 @@
     Pointers = DL.Pointers;
+    NonIntegralAddressSpace = DL.NonIntegralAddressSpace;
     return *this;
----------------
Only one non-integral is supported? I would expect it to support specifying any address space (like the pointer bit widths). I'm not sure we really need more than one, but 2 or 3 seems likely.


https://reviews.llvm.org/D22488