[PATCH] D22890: AArch64: Add missing branch relaxation tests
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 28 11:16:07 PDT 2016
arsenm added inline comments.
================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:134
@@ +133,3 @@
+ // Verify the displacement bits options have sane values.
+ // XXX: Is there a better place for this?
+ assert(MaxOffs >= 8 &&
----------------
rovka wrote:
> I'd rather move this closer to the point of use, because that would make the need for it clearer. But that's just personal preference.
Do you mean into the pass itself?
https://reviews.llvm.org/D22890
More information about the llvm-commits
mailing list