[PATCH] D22341: MinMax Index Pattern Identification

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 10:46:15 PDT 2016


mkuper added a comment.

The problem is that as long as the Yes/No/Maybe interface doesn't get used, it's really hard to understand whether it makes sense.
There may be a better way to handle this, and it's really hard to know without seeing the use.

In this case, I suggest you post a more complete patch (for a new review, with llvm-commits subscribed), even if thought it'll be larger. 
Also, please clang-format the code you're adding before you post the patch for review. There are a lot of 80-column violations here, among other things.


Repository:
  rL LLVM

https://reviews.llvm.org/D22341





More information about the llvm-commits mailing list