[PATCH] D22885: TargetInstrInfo: add virtual function GetInstSizeInBytes

[Duncan P. N. Exon Smith via llvm-commits]

> On 2016-Jul-28, at 06:25, Sjoerd Meijer <sjoerd.meijer at arm.com> wrote:
> 
> SjoerdMeijer updated this revision to Diff 65899.
> SjoerdMeijer added a comment.
> 
> Thanks, that has been fixed.
> 
> 
> https://reviews.llvm.org/D22885
> 
> Files:
>  include/llvm/Target/TargetInstrInfo.h
>  lib/Target/AArch64/AArch64BranchRelaxation.cpp
>  lib/Target/AArch64/AArch64InstrInfo.cpp
>  lib/Target/AArch64/AArch64InstrInfo.h
>  lib/Target/ARM/ARMBaseInstrInfo.cpp
>  lib/Target/ARM/ARMBaseInstrInfo.h
>  lib/Target/ARM/ARMComputeBlockSize.cpp
>  lib/Target/ARM/ARMConstantIslandPass.cpp
>  lib/Target/ARM/ARMFrameLowering.cpp
>  lib/Target/ARM/README-Thumb.txt
>  lib/Target/AVR/AVRInstrInfo.cpp
>  lib/Target/AVR/AVRInstrInfo.h
>  lib/Target/MSP430/MSP430BranchSelector.cpp
>  lib/Target/MSP430/MSP430InstrInfo.cpp
>  lib/Target/MSP430/MSP430InstrInfo.h
>  lib/Target/Mips/MipsConstantIslandPass.cpp
>  lib/Target/Mips/MipsDelaySlotFiller.cpp
>  lib/Target/Mips/MipsInstrInfo.cpp
>  lib/Target/Mips/MipsInstrInfo.h
>  lib/Target/Mips/MipsLongBranch.cpp
>  lib/Target/PowerPC/PPCBranchSelector.cpp
>  lib/Target/PowerPC/PPCISelLowering.cpp
>  lib/Target/PowerPC/PPCInstrInfo.cpp
>  lib/Target/PowerPC/PPCInstrInfo.h
>  lib/Target/SystemZ/SystemZInstrInfo.cpp
>  lib/Target/SystemZ/SystemZInstrInfo.h
> 
> <D22885.65899.patch>
> Index: lib/Target/Mips/MipsLongBranch.cpp
> ===================================================================
> --- lib/Target/Mips/MipsLongBranch.cpp
> +++ lib/Target/Mips/MipsLongBranch.cpp
> @@ -179,7 +179,7 @@
>      // Compute size of MBB.
>      for (MachineBasicBlock::instr_iterator MI = MBB->instr_begin();
>           MI != MBB->instr_end(); ++MI)
> -      MBBInfos[I].Size += TII->GetInstSizeInBytes(*MI);
> +      MBBInfos[I].Size += TII->getInstSizeInBytes(*MI);

The rename seems totally separable.  I suggest changing the names of the existing functions in separate prep commit(s).

>  
>      // Search for MBB's branch instruction.
>      ReverseIter End = MBB->rend();
>