[PATCH] D22865: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 07:12:17 PDT 2016


t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

Looks good with a couple of cleanups to the function now that IsThumb exists.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:7929
@@ -7927,3 +7928,3 @@
   bool IsNeon = UnitSize >= 8;
   TRC = (IsThumb1 || IsThumb2) ? &ARM::tGPRRegClass : &ARM::GPRRegClass;
   if (IsNeon)
----------------
Just as well make this IsThumb now.

================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:8031
@@ -8029,3 +8030,3 @@
 
     if (IsThumb1)
       AddDefaultPred(BuildMI(*BB, MI, dl, TII->get(ARM::tLDRpci)).addReg(
----------------
Also better as isThumb?


https://reviews.llvm.org/D22865





More information about the llvm-commits mailing list