[PATCH] D22885: TargetInstrInfo: add virtual function GetInstSizeInBytes
James Molloy via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 28 03:11:28 PDT 2016
jmolloy added inline comments.
================
Comment at: include/llvm/Target/TargetInstrInfo.h:253
@@ -252,1 +252,3 @@
+ /// Returns the size of the specified MachineInstr.
+ virtual unsigned getInstSizeInBytes(const MachineInstr &MI) const {
----------------
You must document the ~0U sentinel and what it means. Also mention that the unit is "bytes".
https://reviews.llvm.org/D22885
More information about the llvm-commits
mailing list