[llvm] r276942 - Don't invoke getName() from Function::isIntrinsic().
Michel Dänzer via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 28 02:11:41 PDT 2016
On 28.07.2016 17:12, Justin Lebar wrote:
> Hi, Michel.
>
> How do I run this test?
You can reproduce the problem by feeding the LLVM IR I attached to llc.
> I suspect that the issue is @llvm.SI.load.const, because that's the
> only builtin that's being touched here. I'm not at my computer, but
> is that actually a defined intrinsic? If not, this patch would cause
> isIntrinsic() to return false for that function, whereas before it
> would return true (with intrinsic-id == not-an-intrinsic!). If
> something is checking isIntrinsic(), it could be changed to check
> hasLLVMReservedName to get the same behavior we have today.
>
> If this is causing problems for you, feel free to roll back.
> Otherwise I'll sync up with either you or Matt in the morning
> California time.
Please sync up with Matt.
Thanks,
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
More information about the llvm-commits
mailing list