[PATCH] D22896: [LLVM] Add LLVM_ENABLE_LLD option to use LLD as C/C++ linker.

[Saleem Abdulrasool via llvm-commits]

compnerd requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: cmake/modules/HandleLLVMOptions.cmake:15
@@ -14,3 +14,2 @@
 
-
 if (CMAKE_LINKER MATCHES "lld-link.exe")
----------------
Why the whitespace removal?

================
Comment at: cmake/modules/HandleLLVMOptions.cmake:112
@@ -111,3 +110,2 @@
 
-
 function(append value)
----------------
Why the whitespace removal?

================
Comment at: cmake/modules/HandleLLVMOptions.cmake:148
@@ +147,3 @@
+  append_if(CXX_SUPPORTS_LLD "-fuse-ld=lld"
+    CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
+endif()
----------------
We need `CMAKE_MODULE_LINKER_FLAGS` and `CMAKE_SHARED_LINKER_FLAGS`.  This probably works well enough right now due to the fact that the default configuration does not use shared libraries.


Repository:
  rL LLVM

https://reviews.llvm.org/D22896