[PATCH] D22551: CodeGen: If Convert blocks that would form a diamond when tail-merged.

[Kyle Butt via llvm-commits]

iteratee added inline comments.

================
Comment at: lib/CodeGen/IfConversion.cpp:499
@@ +498,3 @@
+  DebugLoc dl;
+  MachineBasicBlock::iterator BBIT = BBI.BB->getFirstTerminator();
+  if (BBIT != BBI.BB->end())
----------------
davidxl wrote:
> Split out the independent fix with a test case if possible
I've removed it. Finding a test case is enough work that I just don't have time.

================
Comment at: lib/CodeGen/IfConversion.cpp:1855
@@ +1854,3 @@
+
+  if (TrueBBI.BB->pred_size() > 1 || FalseBBI.BB->pred_size() > 1) {
+    BBI.IsAnalyzed = false;
----------------
davidxl wrote:
> Why is this check not done for the forked case?
Good catch.


https://reviews.llvm.org/D22551