[PATCH] D22878: [LSV] Don't assume that bitcast ops are Instructions.

[Justin Lebar via llvm-commits]

jlebar added a comment.

There are other places where we're assuming that Builder gives us an instruction when it doesn't, but I'd like to deal with those in a separate patch.


================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:972
@@ -971,2 +971,3 @@
     SmallVector<Instruction *, 16> InstrsToErase;
     SmallVector<Instruction *, 16> InstrsToReorder;
+    // Bitcast might not be an Instruction, if the value being loaded is a
----------------
asbirlea wrote:
> Looking back at this, why do we need a small vector for instructions to reorder and not just one instruction (which now may or may not exist)?
lol, good point.  Fixed.


https://reviews.llvm.org/D22878