[PATCH] D22885: TargetInstrInfo: add virtual function GetInstSizeInBytes

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 13:31:10 PDT 2016


arsenm added a subscriber: arsenm.

================
Comment at: include/llvm/Target/TargetInstrInfo.h:255
@@ +254,3 @@
+  /// Returns the size of the specified MachineInstr. 
+  virtual unsigned GetInstSizeInBytes(const MachineInstr &MI) const {
+    return 4;
----------------
This should start with a lowercase letter. It should also have a default implementation of llvm_unreachable since I don't think guessing 4 is a reasonable default


https://reviews.llvm.org/D22885





More information about the llvm-commits mailing list