[PATCH] D16077: DIBuilder support DI Macro creation

[Adrian Prantl via llvm-commits]

aprantl added a comment.

Yes, I think putting it on DIMacroFile might be a better interface, but I'm not sure.
But then there is also another issue: I'm not sure whether it is legal to modify a uniquable (non-distinct) DINode because it will break uniquing. So I think DIMacroFiles must be created distinct to avoid this problem. Would this cause an issue during LTO with duplication or are they expected to be mostly unique across compile units anyway?


https://reviews.llvm.org/D16077