[PATCH] D22877: AMDGPU: Turn dead checks into asserts

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 11:37:06 PDT 2016


arsenm added a comment.

In https://reviews.llvm.org/D22877#498006, @nhaehnle wrote:

> The INT_TO_FP ones look good to me. The other I'm not sure of because the SelectS_BFE path only applies to GCN. If you made sure that the R600 case is covered by a test or irrelevant, then this change is fine with me.


R600 is covered by tests already. It just selects BFE with td patterns. The S_BFE case required custom code I think because of the way the operands are packed in the scalar version vs. the node/vector version


https://reviews.llvm.org/D22877





More information about the llvm-commits mailing list