[PATCH] D22744: CodeExtractor : Add ability to preserve profile data.

River Riddle via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 11:15:48 PDT 2016


rriddle added inline comments.

================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:808
@@ +807,3 @@
+        BFI->getProfileCountFromFreq(EntryFreq.getFrequency());
+    newFunction->setEntryCount( OptEntryCount.getValue());
+    BFI->setBlockFreq(codeReplacer, EntryFreq.getFrequency());
----------------
davidxl wrote:
> silvas wrote:
> > nit: no space after the open paren
> The check should be here: if optEntryCount has value (hasValue() returns true, not >0), set it to the newFunction entry.    hasValue is false when PGO is not enabled.
> 
> 
Thanks for the clarification, I was unsure if it should just be for the entry count.


https://reviews.llvm.org/D22744





More information about the llvm-commits mailing list